Add basic MySQL TLS support #4794
Open
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, please rebase and hopefully things will pass now. |
Johno-ACSLive
force-pushed
the
develop
branch
from
f1876b1 to
71a2277
Compare
|
Docker Image for build 5 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
Hi, done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds minimal, opt‑in TLS support for MySQL connections in Nginx Proxy Manager. It introduces three environment variables:
DB_MYSQL_SSLfalseDB_MYSQL_SSL_REJECT_UNAUTHORIZEDtrueDB_MYSQL_SSL_VERIFY_IDENTITYtrueNo behavior changes for existing users unless
DB_MYSQL_SSLis explicitly enabled. Does not impact other DB engine configuration.Motivation
Environments such as:
require_secure_transport=ON…currently cause startup failure (
ER_SECURE_TRANSPORT_REQUIRED) because connection attempts are plaintext. This update allows secure connections while remaining completely backward compatible.Backward Compatibility
DB_MYSQL_SSL=true)DB_MYSQL_SSL_REJECT_UNAUTHORIZED=false)DB_MYSQL_SSL_VERIFY_IDENTITY=trueOut of Scope / Future Work